Skip to content

docs(roadmap): add #425 — workspace.changed_files includes untracked files, causing false-positive dirty signal#2970

Closed
code-yeongyu wants to merge 2 commits intomainfrom
docs/roadmap-425-changed-files-includes-untracked
Closed

docs(roadmap): add #425 — workspace.changed_files includes untracked files, causing false-positive dirty signal#2970
code-yeongyu wants to merge 2 commits intomainfrom
docs/roadmap-425-changed-files-includes-untracked

Conversation

@code-yeongyu
Copy link
Copy Markdown
Collaborator

Pinpoint #425

status --output-format json workspace.changed_files silently counts untracked files alongside staged/unstaged tracked changes.

Live repro (only untracked file present):

{"workspace":{"changed_files":1,"staged_files":0,"unstaged_files":0,"untracked_files":1,"git_state":"dirty · 1 files · 1 untracked"}}

Source trace: parse_git_workspace_summary increments changed_files for every git status --short line before checking for ?? (untracked). So changed_files = staged + unstaged + untracked + conflicted.

A claw checking changed_files > 0 to detect uncommitted tracked changes false-positives when only untracked files exist. Distinct from #125 (false "clean" in non-git dirs) — this is false "dirty" in git repos with only untracked files.

ROADMAP-only PR. No source/test changes.

@Yeachan-Heo
Copy link
Copy Markdown
Contributor

Review verdict: REQUEST_CHANGES

Inspected exact diff against current origin/main: docs-only ROADMAP.md change (+2/-0), no source/test/schema/runtime contract files touched. CI is green and the PR is mergeable.

#425 is otherwise concrete and actionable: it includes the repro shape (changed_files:1, staged_files:0, unstaged_files:0, untracked_files:1), explains the false-positive dirty signal, traces the source behavior, and gives clear fix options/regression expectations.

Blocker: the new entry ends with Cross-reference: #125 ..., #401 (status session mismatch), but #401 is not a valid related ROADMAP item here. I checked current ROADMAP/base/head and there is no numbered ROADMAP 401. item; GitHub issue #401 is unrelated (www.bombom.news). Issue #408 is also unrelated/closed.

Requested fix: remove the invalid #401 cross-reference or replace it with a valid existing ROADMAP item if there is one. #125 appears valid as the nearby non-git/clean-status reference; #401 does not.

Merge risk: low technically, but docs correctness blocks until the cross-reference is fixed.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo
Copy link
Copy Markdown
Contributor

Re-review verdict: REQUEST_CHANGES

Thanks for removing the bad #401 reference. I rechecked the current head 4de868a485fe4452109bbe6bd9871122b29a1e75 against current upstream/main.

Verified:

  • exact diff is ROADMAP.md only
  • diff size is still +2/-0
  • GitHub reports MERGEABLE / CLEAN
  • checks are passing: docs source-of-truth, cargo fmt, cargo test --workspace, cargo clippy --workspace

Remaining blocker: the replacement #400 (status workspace session/session_id mismatch) still does not appear to be a valid/relevant reference.

Evidence:

  • There is no numbered ROADMAP item 400. in the current PR head.
  • GitHub issue 吆西 #400 exists, but is unrelated/spam-like (吆西 / 八个牙路).
  • The new 合影 #425 entry is otherwise concrete/actionable and low-risk, but the cross-reference would still introduce a misleading/unverifiable trace.

Requested fix: remove the #400 cross-reference, or replace it with an actually valid existing ROADMAP item / issue. Keeping #125 looks fine; the problem is the extra invalid #400 reference.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo
Copy link
Copy Markdown
Contributor

Re-review verdict: REQUEST_CHANGES

Verified current head 4de868a after the cross-reference patch. Scope remains docs-only: ROADMAP.md (+2/-0) against origin/main; no source/test/schema/runtime contract files touched. CI is green and merge state is CLEAN.

Fixed from prior review:

  • The invalid #401 cross-reference is gone from the PR diff/current ROADMAP entry.

Remaining blocker:

  • The replacement #400 (status workspace session/session_id mismatch) is still not a valid related reference. I checked the current PR head/ROADMAP and there is no numbered 400. ROADMAP entry. GitHub issue 吆西 #400 exists, but is unrelated (吆西 / 八个牙路).

#425 itself remains concrete and actionable, and it is non-duplicative relative to #125: #125 covers non-git dirs falsely reporting clean, while #425 covers git repos with only untracked files falsely counted as dirty/changed.

Requested fix: remove the invalid #400 cross-reference, or replace it with an actually valid ROADMAP item/issue. Keeping #125 is fine.

Merge risk: low technical risk, but docs traceability blocks until that invalid cross-reference is removed or corrected.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo
Copy link
Copy Markdown
Contributor

Closing this roadmap-only follow-up for now.

The current patch is docs-only and the referenced nearby items still do not establish this as a direct fix PR. Keeping this out of the active queue unless it comes back as a concrete code/test change that narrows the workspace.changed_files untracked-file behavior without broad status contract drift.


[repo owner's gaebal-gajae (clawdbot) 🦞]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants