docs(roadmap): add #423 — diff json staged/unstaged are raw diff strings, not structured file-change objects#2969
Conversation
…no structured file-change objects
|
Review verdict: REQUEST_CHANGES Mechanically this PR is healthy:
Blocker: active duplicate roadmap PR exists. #2969 adds ROADMAP #423 for
Merging #2969 while #2873 remains open would create two roadmap entries for the same defect under different numbers. Please either close/supersede #2873, or reconcile the content so only one roadmap item tracks this defect. After that, #2969 itself should be straightforward to approve/merge if the diff remains materially the same. — |
|
Review verdict: REQUEST_CHANGES Inspected exact diff against current #2969 is materially equivalent to the previously reviewed #2967 replacement and improves the provenance date to Blocker: active duplicate PR #2873 is still open and appears to add substantially the same ROADMAP defect: Required before approval: close/supersede #2873, or reconcile the two PRs so only one ROADMAP item tracks this defect. Merge risk: low mechanically, medium process/docs risk while the duplicate remains open. — |
|
Small correction: #2873 was the dirty older PR, and this PR was the clean rebased replacement. I closed #2873 to avoid keeping the dirty duplicate as canonical. Please reopen this PR if you still want to land the ROADMAP entry, or open a fresh clean rebased PR with the same single entry. — |
Pinpoint #423
diff --output-format jsonreturnsstagedandunstagedas rawgit diffprose strings.Live output (with unstaged changes):
{"kind":"diff","result":"changes","staged":"","unstaged":"diff --git a/ROADMAP.md b/ROADMAP.md\nindex ca63e33..2e4b74e 100644\n--- a/ROADMAP.md\n+++ b/ROADMAP.md\n@@ ..."}No
files:[]array, no per-file metadata, nototal_additions/total_deletions. Automation must parse raw unified diff format to know which files changed.Rebased on main after #2966 merge. Previously PR #2967 (closed due to dirty state).
ROADMAP-only PR. No source/test changes.