Skip to content

Remove circular FW and blanket, and create ivc_tools.py for common fns#4235

Merged
timothy-nunn merged 2 commits intomainfrom
ivc-tools
May 8, 2026
Merged

Remove circular FW and blanket, and create ivc_tools.py for common fns#4235
timothy-nunn merged 2 commits intomainfrom
ivc-tools

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented May 8, 2026

Description

Removes circular imports of blanket and first wall
Moves functions common to IVCs into separate file, instead of being within the blanket_library.py:
calculate_pipe_bend_radius, dshellarea, dshellvol, eshellarea, eshellvol

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2026

Codecov Report

❌ Patch coverage is 89.39394% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.52%. Comparing base (e06cfce) to head (a7debef).

Files with missing lines Patch % Lines
process/models/engineering/ivc_functions.py 90.74% 5 Missing ⚠️
process/models/blankets/dcll.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4235   +/-   ##
=======================================
  Coverage   51.52%   51.52%           
=======================================
  Files         150      151    +1     
  Lines       30116    30117    +1     
=======================================
+ Hits        15516    15517    +1     
  Misses      14600    14600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould marked this pull request as ready for review May 8, 2026 10:32
@clmould clmould requested a review from a team as a code owner May 8, 2026 10:32
Comment thread process/models/engineering/ivc_functions.py
Comment thread process/models/ivc_tools.py Outdated
Comment thread process/models/ivc_tools.py Outdated
Comment thread process/models/engineering/ivc_functions.py
@clmould clmould requested a review from timothy-nunn May 8, 2026 15:18
@timothy-nunn timothy-nunn merged commit 14c6151 into main May 8, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the ivc-tools branch May 8, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants