FEAT: move image sharing documentation from gitlab repo to docs#82
Open
dwheel7 wants to merge 4 commits intouabrc:mainfrom
Open
FEAT: move image sharing documentation from gitlab repo to docs#82dwheel7 wants to merge 4 commits intouabrc:mainfrom
dwheel7 wants to merge 4 commits intouabrc:mainfrom
Conversation
jprorama
reviewed
Dec 10, 2025
wwarriner
requested changes
Dec 10, 2025
Contributor
wwarriner
left a comment
There was a problem hiding this comment.
Great start!
Stylistic consistency is key. A key goal of documentation is ease of use, which means minimizing the mental workload of the reader in understanding our docs. Part of that is ensuring consistent style: voice, tense, and mood. I've left specific comments, but didn't mark every instance of inconsistency, so you'll need to review each part.
I recommend sticking to what "active, present imperative" style. It is very easy to read and understand.
Source the openrc file from your openstack project.
Contributor
|
FYI I cannot merge this because I've contributed a change (to resolve the mkdocs.yml conflict). @diedpigs are you able to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Intent
take documentation on sharing images in openstack from our gitlab repo to the docs site
Proposed Changes
add new page of documentation and updated nav to link to new page