Fix: Prevent OBD signal merging, preserve distinct metrics, and cache definitions#147
Merged
Conversation
Implement 7-day `localStorage` caching in `SignalRegistry.init()` to prevent fetching OBD dictionaries on every page load.
|
Coverage after merging feat/rework-signals-importing into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a critical data parsing bug where distinct telemetry signals (e.g., "Boost Target" and "Boost Measured") were being incorrectly merged into a single generic chart series (e.g., "Boost"). It also introduces a caching layer to improve application load times.
What Changed
SignalRegistry.#mergeMetadatato preserve the full, exact English descriptions from the OBD JSON files by replacing newlines with spaces (instead of splitting and truncating).SignalRegistry.getCanonicalKey()that was causing the UI to collapse specific names back into generic buckets.DataProcessor.#normalizeColumnarJSON. It now cleanly maps PIDs directly to their specific English translations.localStoragecache (TTL) toSignalRegistry.init()so the app no longer downloads the large definition dictionaries on every single page load.