Support for quoted identifiers#1307
Open
matejcerny wants to merge 1 commit into
Open
Conversation
matejcerny
force-pushed
the
quoted-identifiers
branch
from
059f5d6 to
a19d05f
Compare
matejcerny
commented
May 13, 2026
| def asSql: String = if (quoted) s"\"${value.replace("\"", "\"\"")}\"" else value | ||
| override def toString: String = asSql | ||
|
|
||
| override def equals(other: Any): Boolean = other match { |
Author
There was a problem hiding this comment.
Not sure if this can break anything?
matejcerny
commented
May 13, 2026
| val identifier: SCodec[Identifier] = | ||
| utf8z.exmap( | ||
| s => Attempt.fromEither(Identifier.fromString(s).leftMap(Err(_))), | ||
| s => Attempt.fromEither(Identifier.fromString(s).orElse(Identifier.fromStringQuoted(s)).leftMap(Err(_))), |
Author
There was a problem hiding this comment.
Any idea if there is a better solution?
matejcerny
force-pushed
the
quoted-identifiers
branch
from
a19d05f to
214acdf
Compare
Author
|
It's a much bigger change than I originally thought 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements #1276