Skip to content

Skip multi-parent recombinants#606

Merged
jeromekelleher merged 1 commit into
tskit-dev:mainfrom
szhan:update_recomb_summary
May 8, 2026
Merged

Skip multi-parent recombinants#606
jeromekelleher merged 1 commit into
tskit-dev:mainfrom
szhan:update_recomb_summary

Conversation

@szhan
Copy link
Copy Markdown
Member

@szhan szhan commented May 8, 2026

Fix #605

@szhan szhan marked this pull request as draft May 8, 2026 14:11
@szhan szhan force-pushed the update_recomb_summary branch from 037d2c0 to 66f5932 Compare May 8, 2026 14:12
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.07%. Comparing base (f7927ef) to head (66f5932).

Files with missing lines Patch % Lines
sc2ts/debug.py 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   88.14%   88.07%   -0.07%     
==========================================
  Files          12       12              
  Lines        4132     4134       +2     
  Branches      584      585       +1     
==========================================
- Hits         3642     3641       -1     
- Misses        363      365       +2     
- Partials      127      128       +1     
Flag Coverage Δ
python-tests 88.07% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeromekelleher
Copy link
Copy Markdown
Member

Happy to merge ilthis if it unblocks the pipeline

@jeromekelleher
Copy link
Copy Markdown
Member

It's marked WIP so assuming you don't want it merged yet?

@szhan
Copy link
Copy Markdown
Member Author

szhan commented May 8, 2026

Oops, I was just running it on the ARG just to check. Good to merge now, I think.

@szhan szhan marked this pull request as ready for review May 8, 2026 14:31
@jeromekelleher jeromekelleher merged commit 1bd7cbb into tskit-dev:main May 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ArgInfo.recombinants_summary to handle multi-parent recombinants

3 participants