chore(server): remove dead pending-command dedup block#167
Merged
Conversation
The helper lived under #if 0 and was never compiled; the only call site in SV_AddServerCommand was commented out. Drop the dead code and stale comments to reduce noise without changing server command behavior. Co-authored-by: Tim Fox <timfox@outlook.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Author
There was a problem hiding this comment.
Security review complete. I found no high-confidence medium-or-higher security vulnerabilities introduced or exposed by this PR.
Scope checked: the diff only removes an #if 0 helper and a commented-out call in SV_AddServerCommand; the active server-command queuing path and its existing overflow/length controls are unchanged. No prior automation review threads were present to revalidate.
Sent by Cursor Automation: Find vulnerabilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a permanently disabled (
#if 0) helper and related commented-out call site inSV_AddServerCommand. No runtime behavior change.Flags removed
None. This repository does not use a centralized feature-flag registry; engine toggles are mostly
cvar_tand CMake/renderer defines. This change removes a dead compile-time branch only.Why this is safe to delete
SV_ReplacePendingServerCommandswas wrapped in#if 0 // unusedand was never compiled.SV_AddServerCommandwas commented out; live code always took the path that skips deduplication and proceeds as today.Behavioral parity checks performed
./scripts/compile_engine.sh opengl(succeeded).ctestfrombuild-gl-Release: 19/19 tests passed (smoke test, renderer regression check, unit tests, script tests).