chore(render): remove permanently-disabled renderer branches#161
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
chore(render): remove permanently-disabled renderer branches#161cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Remove `if (0 && …)` dead code for lightmap debug visualization, optional fastsky color clear in RB_BeginDrawingView, and RB_DrawSun after surfaces (already commented as disabled). Behavior matches the previous always-false conditionals. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes dead conditional branches that were gated by
if (0 && …)in Vulkan and OpenGL renderers. These were never reachable at runtime.Flags removed
Not traditional named feature flags or cvars. Effective toggles removed:
r_lightmap == 2path inR_ProcessLightmap)if (0 && r_lightmap->integer == 2)r_fastskyinRB_BeginDrawingViewif (0 && r_fastsky->integer && …)RB_DrawSunafter draw-surfacesif (0 && r_drawSun->integer)Cvars
r_lightmap,r_fastsky, andr_drawSunremain registered for other code paths (e.g. flat sky, lightmap-only views).Why this is safe
0 && …), so execution always followed theelse/fall-through that remains.Behavioral parity checks
./scripts/compile_engine.sh vulkan— successctestinbuild-vk-Release— 19/19 tests passed (smoke, renderer regression check, unit tests)Candidates not changed (low confidence / out of scope)
USE_*options (Opus, curl, optional codecs): still meaningful build toggles, not “rolled out.”r_forwardPlus: documented optional scaffolding, default off — removing would change supported behavior.