Remove dead renderer feature gates (r_drawSun, disabled branches)#159
Merged
Remove dead renderer feature gates (r_drawSun, disabled branches)#159
Conversation
- Drop if(0) gated lightmap dev path, fastsky color clear, and sun draw - Remove unused RB_DrawSun and r_drawSun (no remaining references) - Mirror changes in OpenGL and Vulkan for parity Co-authored-by: Tim Fox <timfox@outlook.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Author
There was a problem hiding this comment.
Security review complete: no high-confidence medium, high, or critical vulnerabilities found in this PR.
I validated that the modified code only removes dead renderer gates/disabled sun drawing paths and simplifies the existing lightmap processing branch; I did not find any new attacker-controlled input reaching an unsafe sink. No inline findings are being reported.
Sent by Cursor Automation: Find vulnerabilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags / toggles removed
r_drawSun(cvar): Registration andcvar_t/ extern declarations were removed. The only call path was underif ( 0 && r_drawSun->integer ), so the cvar had no effect on any build.Why this is safe
if ( 0 && … ), so the compiler never executed them; behavior was already that of theelse/ fall-through path.r_drawSunwas orphaned: After removing the dead call site, there were no remaining references; removing the cvar matches actual engine behavior (sun quad was never drawn).Behavioral parity
./scripts/compile_engine.sh vulkanandopenglbuilds succeeded;ctestinbuild-vk-Release(19 tests including smoke and renderer checks) passed.RB_DrawSun.