Vulkan: remove dead USE_FOG_ONLY compile-time branch#151
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Vulkan: remove dead USE_FOG_ONLY compile-time branch#151cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
USE_FOG_ONLY was unconditionally defined in tr_local.h with no CMake toggle; the #else paths were unreachable. Keep the TYPE_FOG_ONLY fog pass behavior and drop the macro and dead code. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the always-on compile-time
USE_FOG_ONLYgate from the Vulkan renderer. The macro was unconditionally defined intr_local.hwith no build toggle, so the#elsebranches were dead code.Flags removed
USE_FOG_ONLY(compile-time define insrc/renderers/vulkan/tr_local.h)Why it is safe to delete
tr_local.h; CMake and other sources did not undefine or override it.#elsepath mixed vertex-color fog setup with Vulkan pipeline binding and was unreachable in any shipped configuration.USE_FOG_ONLY; behavior there is unchanged.Behavioral parity
TYPE_FOG_ONLYpipelines,VK_SetFogParams,VK_DESC_FOG_ONLY, and the same draw path as before (previously the only live branch)../scripts/compile_engine.sh vulkan(success).ctestinbuild-vk-Release— all 19 tests passed (smoke, renderer regression, unit suite).