docs: Vulkan effective render target (vk_get_render_target_*)#149
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
docs: Vulkan effective render target (vk_get_render_target_*)#149cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Explain the FBO main-color vs vk.renderWidth fallback chain from vk_view_state.c so internal scale, Forward+, SSAO, SSR, and temporal reset behavior are easier to reason about. Tighten ARCHITECTURE Forward+ line to match the same source of truth. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the resolution order for
vk_get_render_target_width()/vk_get_render_target_height()so Vulkan subsystem docs matchsrc/renderers/vulkan/vk_view_state.c.Changes
docs/RENDERERS.md— Under Internal Resolution / Present Scaling, adds a bullet describing the FBO main-color →vk.render*→glConfigfallback, whyvk.renderWidthcan diverge mid-frame (e.g. sun shadow pass), and which systems rely on this helper (Forward+, SSAO/HBAO, SSR copy, temporal reset), with file pointers.docs/ARCHITECTURE.md— Clarifies the Forward+ bullet so “tile buffers follow …” names the same source of truth as the implementation.Why
Recent Vulkan work standardized post-FX and Forward+ packing on this helper; the long-form audit and
RENDERER_2026_ARCHITECTURE_PASS.mdalready mention it—the feature doc and architecture overview were the weak link for quick scanning.