fix(test): add teat_autoware module (imu_corrector)#687
Open
fix(test): add teat_autoware module (imu_corrector)#687
Conversation
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
…verter Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
…rgo fmt 1 Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/tier4/awkernel/sessions/2a6ef5c8-5491-440d-bebf-6968b2fa5827 Co-authored-by: nokosaaan <106376734+nokosaaan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/tier4/awkernel/sessions/2a6ef5c8-5491-440d-bebf-6968b2fa5827 Co-authored-by: nokosaaan <106376734+nokosaaan@users.noreply.github.com>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
There was a problem hiding this comment.
Pull request overview
Adds a new optional test_autoware test application to the userland runtime and introduces Autoware-related test crates (including an imu_corrector implementation and unit tests) under applications/tests/test_autoware.
Changes:
- Wire a new
test_autowarefeature intouserlandand calltest_autoware::run()when enabled. - Add a new
applications/tests/test_autowarecrate plus subcrates forimu_driver,imu_corrector, andvehicle_velocity_converter. - Implement unit-test-style validation for message conversions / corrections in the new subcrates.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| userland/src/lib.rs | Adds feature-gated call to test_autoware::run() from the main runtime entrypoint. |
| userland/Cargo.toml | Adds optional dependency + feature flag for test_autoware. |
| applications/tests/test_autoware/src/lib.rs | Introduces test_autoware crate entrypoint (run()), currently empty. |
| applications/tests/test_autoware/Cargo.toml | Defines the test_autoware crate dependencies (currently missing imu_corrector). |
| applications/tests/test_autoware/imu_driver/src/lib.rs | Adds imu_driver parsing/generation logic plus unit tests. |
| applications/tests/test_autoware/imu_driver/Cargo.toml | Declares the imu_driver crate. |
| applications/tests/test_autoware/imu_corrector/src/lib.rs | Adds imu_corrector logic (bias/covariance/TF handling) plus unit tests. |
| applications/tests/test_autoware/imu_corrector/Cargo.toml | Declares the imu_corrector crate and its dependencies. |
| applications/tests/test_autoware/vehicle_velocity_converter/src/lib.rs | Adds vehicle_velocity_converter conversion + covariance logic plus unit tests. |
| applications/tests/test_autoware/vehicle_velocity_converter/Cargo.toml | Declares the vehicle_velocity_converter crate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added the
imu_correctormodule.Basically, I added it in the same format as
imu_driverandvehicle_velocity_converter, but since I could only find test code forgyro_bias_estimatorand not forimu_corrector_core, I added tests to verify the correctness of the input and output as a substitute, similar toimu_driver.Related links
https://github.com/autowarefoundation/autoware_universe/tree/main/sensing/autoware_imu_corrector/test
How was this PR tested?
You should add the path to the Cargo.toml file you want to unit test to the
memberssection of theworkspacein the root directory's Cargo.toml (at/awkernel/Cargo.toml)imu_corrector.log
Notes for reviewers