Skip to content

fix(test): add teat_autoware module (imu_corrector)#687

Open
nokosaaan wants to merge 50 commits intomainfrom
imu_corrector
Open

fix(test): add teat_autoware module (imu_corrector)#687
nokosaaan wants to merge 50 commits intomainfrom
imu_corrector

Conversation

@nokosaaan
Copy link
Copy Markdown
Contributor

@nokosaaan nokosaaan commented Apr 27, 2026

Description

I added the imu_corrector module.
Basically, I added it in the same format as imu_driver and vehicle_velocity_converter, but since I could only find test code for gyro_bias_estimator and not for imu_corrector_core, I added tests to verify the correctness of the input and output as a substitute, similar to imu_driver.

Related links

https://github.com/autowarefoundation/autoware_universe/tree/main/sensing/autoware_imu_corrector/test

How was this PR tested?

You should add the path to the Cargo.toml file you want to unit test to the members section of the workspace in the root directory's Cargo.toml (at /awkernel/Cargo.toml)
imu_corrector.log

Notes for reviewers

Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
…verter

Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
nokosaaan and others added 15 commits April 20, 2026 18:46
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
…rgo fmt 1

Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/tier4/awkernel/sessions/2a6ef5c8-5491-440d-bebf-6968b2fa5827

Co-authored-by: nokosaaan <106376734+nokosaaan@users.noreply.github.com>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
@nokosaaan nokosaaan changed the title Imu corrector fix(test): add teat_autoware module (imu_corrector) Apr 27, 2026
@nokosaaan nokosaaan requested a review from Copilot April 27, 2026 12:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new optional test_autoware test application to the userland runtime and introduces Autoware-related test crates (including an imu_corrector implementation and unit tests) under applications/tests/test_autoware.

Changes:

  • Wire a new test_autoware feature into userland and call test_autoware::run() when enabled.
  • Add a new applications/tests/test_autoware crate plus subcrates for imu_driver, imu_corrector, and vehicle_velocity_converter.
  • Implement unit-test-style validation for message conversions / corrections in the new subcrates.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
userland/src/lib.rs Adds feature-gated call to test_autoware::run() from the main runtime entrypoint.
userland/Cargo.toml Adds optional dependency + feature flag for test_autoware.
applications/tests/test_autoware/src/lib.rs Introduces test_autoware crate entrypoint (run()), currently empty.
applications/tests/test_autoware/Cargo.toml Defines the test_autoware crate dependencies (currently missing imu_corrector).
applications/tests/test_autoware/imu_driver/src/lib.rs Adds imu_driver parsing/generation logic plus unit tests.
applications/tests/test_autoware/imu_driver/Cargo.toml Declares the imu_driver crate.
applications/tests/test_autoware/imu_corrector/src/lib.rs Adds imu_corrector logic (bias/covariance/TF handling) plus unit tests.
applications/tests/test_autoware/imu_corrector/Cargo.toml Declares the imu_corrector crate and its dependencies.
applications/tests/test_autoware/vehicle_velocity_converter/src/lib.rs Adds vehicle_velocity_converter conversion + covariance logic plus unit tests.
applications/tests/test_autoware/vehicle_velocity_converter/Cargo.toml Declares the vehicle_velocity_converter crate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread applications/tests/test_autoware/imu_corrector/src/lib.rs Outdated
Comment thread applications/tests/test_autoware/imu_corrector/Cargo.toml Outdated
Comment thread applications/tests/test_autoware/Cargo.toml
Comment thread applications/tests/test_autoware/src/lib.rs
Comment thread applications/tests/test_autoware/imu_corrector/src/lib.rs Outdated
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/tier4/awkernel_sync/commits/HEAD
    • Triggering command: REDACTED, pid is -1 (http block)
  • https://api.github.com/repos/ytakano/acpi/commits/HEAD
    • Triggering command: /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/cargo test -p imu_corrector (http block)

If you need me to access, download, or install something from one of these locations, you can either:

nokosaaan and others added 2 commits April 27, 2026 22:03
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nokosaaan nokosaaan marked this pull request as ready for review April 27, 2026 13:08
@nokosaaan nokosaaan requested a review from kobayu858 April 27, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants