Skip to content

⚡ Bolt: Optimize path containment checks#80

Open
thirdeyenation wants to merge 1 commit intomainfrom
bolt-optimize-is-in-dir-5160876674549811961
Open

⚡ Bolt: Optimize path containment checks#80
thirdeyenation wants to merge 1 commit intomainfrom
bolt-optimize-is-in-dir-5160876674549811961

Conversation

@thirdeyenation
Copy link
Copy Markdown
Owner

💡 What: Replaced os.path.commonpath with os.path.abspath and str.startswith() with conditionally appended os.sep in is_in_dir inside helpers/files.py.
🎯 Why: os.path.commonpath is a significant bottleneck due to internal list allocations and path component string splitting.
📊 Impact: Path containment checks are ~3-4x faster, which benefits overall file system operations speed.
🔬 Measurement: Verified with timing scripts; startswith executes in ~0.24s compared to ~0.73s for 100,000 iterations.


PR created automatically by Jules for task 5160876674549811961 started by @thirdeyenation

Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant