feat: collapse task queues to default by TaskQueueResolver#749
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abc1bbafe0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ($worker->pipelineProvider !== null | ||
| || $worker->logger !== null | ||
| || $worker->plugins !== null |
There was a problem hiding this comment.
When a feature uses #[Worker(options: ...)] without also setting a pipeline/logger/plugins, this resolver falls through to the shared default queue unless the test is manually hard-coded in SHARED_QUEUE_EXCLUSIONS. In that case worker.php reuses the already-created default worker, so WorkerFactory::createWorker() never applies that feature's custom WorkerOptions (the existing Deployment test has to be special-cased for this). Treating options like the other Worker fields here would keep future options-only features from silently running with the default worker configuration.
Useful? React with 👍 / 👎.
1 participant
What was changed
Let tests engine not create a new task queue on each test file
Why?
This simplifies RR pollers job by reducing number of pollers.
Less task queues, less stream context switch
Checklist
Closes
How was this tested: