feat: expose side effect summary#700
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f60624473
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * | ||
| * @since RoadRunner 2025.1.2 | ||
| */ | ||
| #[Marshal(name: 'Summary')] |
There was a problem hiding this comment.
summary
RoadRunner decodes side-effect metadata from the JSON option field summary (the same lowercase shape used locally by NewTimer), but this marshalling annotation emits Summary; WorkflowContext forwards the marshalled array unchanged into the SideEffect request. In workflows that call SideEffectOptions::new()->withSummary(...), the worker therefore sends the wrong option key and the server ignores the summary, so the advertised UI/CLI side-effect summary never appears.
Useful? React with 👍 / 👎.
xepozz
force-pushed
the
side-effect-summary
branch
from
0f60624 to
839c7d2
Compare
1 participant
What was changed
Why?
It was added to the roadrunner-temporal plugin
temporalio/roadrunner-temporal@dd820b4#diff-ced8eb545a6b8312d9afc5adb906cda8f06385c2feb986191d4fcb929e4ceb7fL275
Checklist
Closes
How was this tested: