Open
Conversation
Evanthx
force-pushed
the
signals-nexus-python
branch
from
d11d1a0 to
83386cf
Compare
Contributor
VegetarianOrc
left a comment
VegetarianOrc
left a comment
There was a problem hiding this comment.
Code looks okay to me! A few comments throughout.
Left a couple of comments to help me understand the motivation for the structure of the samples as well.
Would like to clear up the intention around removing the sync operation sample before approving.
Comment on lines
+12
to
+16
| The caller workflow: | ||
| 1. Queries for supported languages (`get_languages` -- backed by a `@workflow.query`) | ||
| 2. Changes the language to Arabic (`set_language` -- backed by a `@workflow.update` that calls an activity) | ||
| 3. Confirms the change via a second query (`get_language`) | ||
| 4. Approves the workflow (`approve` -- backed by a `@workflow.signal`) |
Contributor
There was a problem hiding this comment.
Nit: The caller workflow only executes nexus operations and it feels a bit confusing to call out that they're backed by workflow.query/update/signal. IMO that info should be called out about or alongside the service handler.
Author
There was a problem hiding this comment.
Since this is demonstrating queries, updates and signals this does actually feel useful to me though
VegetarianOrc
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is sample code to show two ways to send messages (signals, queries, and updates) through Nexus.