Remove time.Sleep() in commands.taskqueue_test.go#1020
Open
hussam-salah wants to merge 1 commit intotemporalio:mainfrom
Open
Remove time.Sleep() in commands.taskqueue_test.go#1020hussam-salah wants to merge 1 commit intotemporalio:mainfrom
hussam-salah wants to merge 1 commit intotemporalio:mainfrom
Conversation
- remove time.Sleep() needed before v1.26.2 because of server cache bug - update test assertions of "2 seconds ago" to "now" since we won't wait JAVA_HOME="/Users/hussamsalah/Library/Java/JavaVirtualMachines/graalvm-ce-25.0.2/Contents/Home"
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
test
TestTaskQueue_Describe_Simpleatcommands.taskqueue_test.gowas updated to remove unnecessarytime.Sleep(1 * time.Second)Why?
The waiting was a necessary workaround of server cache bug, bug was fixed on v1.26.2
Checklist
Closes
[Feature Request] Remove time.Sleep() in commands.taskqueue_test.go #741
How was this tested:
Running the unit tests