Skip to content

Use payload input options for activity complete results#1010

Open
arjunrawal1 wants to merge 1 commit intotemporalio:mainfrom
arjunrawal1:arjun/payload-input-activity-complete
Open

Use payload input options for activity complete results#1010
arjunrawal1 wants to merge 1 commit intotemporalio:mainfrom
arjunrawal1:arjun/payload-input-activity-complete

Conversation

@arjunrawal1
Copy link
Copy Markdown

What changed

  • Replaces the activity complete --result string flag with the shared PayloadInputOptions flags.
  • Updates help text/generated command code to show --input.
  • Updates activity completion tests to use the shared payload input path.

Why

This makes activity complete consistent with other CLI commands that accept payload input, including support for --input-file, --input-base64, and --input-meta.

Closes #446.

Testing

  • go test ./cmd/gen-commands
  • go test ./internal/temporalcli -run 'TestSharedServerSuite/TestActivity_Complete|TestSharedServerSuite/TestActivity_Complete_InvalidResult'\n- go test ./internal/temporalcli -run 'TestSharedServerSuite/TestActivity_Complete_ByRunId'\n- go test ./cmd/temporal

@arjunrawal1 arjunrawal1 requested a review from a team as a code owner April 29, 2026 05:33
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 29, 2026

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI Refresh] Consistent payload input options across all commands

2 participants