Added loadMessageParts method to recursively process structure->parts#105
Open
M1ke wants to merge 2 commits intotedious:masterfrom
Open
Added loadMessageParts method to recursively process structure->parts#105M1ke wants to merge 2 commits intotedious:masterfrom
M1ke wants to merge 2 commits intotedious:masterfrom
Conversation
Member
|
The only reason it's failing tests is because of code styling- if you run the code fixer instructions in the contributing dock it should be good. I still need to give it a code review, but the fact that nothing is broken is a pretty good sign. |
Author
|
OK thanks, will let you know once I've had chance to update. |
Author
|
@tedivm given we fixed the styling issues might it be possible to merge this? |
Member
|
Any reason why code coverage decreased? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in this issue