Switch from eslint to biome#108
Merged
Eijebong merged 6 commits intotaskcluster:mainfrom May 5, 2026
Merged
Conversation
Contributor
Author
|
#109 will fix CI |
matt-boris
approved these changes
May 5, 2026
Contributor
matt-boris
left a comment
matt-boris
left a comment
There was a problem hiding this comment.
Nice, thanks. LGTM. And I approved the one that'll fix this one's CI. Feel free to merge that other and rebase/merge this one 👍🏻
Eslint is a pain to update, half the plugins are working with 8 only, the other half with 9, meanwhile eslint is now on 10. Instead of pulling half of the internet, switch to biome which in my experience is stricter regarding lints and also faster. And a lot less painful to update.
This fixes biome's `noAssignInExpressions` warnings which really didn't like the `foo = exports.foo = function ()` pattern. I would've fixed this by using `export function foo()` instead but that requires converting this lib to ESM which is another project... In the meantime, the result is a lot cleaner IMO, it's way easier to see the public API for this library now.
Fixes biome's `useConst` linter warnings.
I excluded `src/**` from that check since it was complaining about `assert` there which actually gets polyfilled. But for tests, this is correct. Fixes biome's `useNodejsImportProtocol` lint.
Fixes biome's `useTemplate` warning.
This formats the code as biome wants it. This is unfortunately a bit noisy, I reduced the diff as much as possible by trying to match the rules with eslint but there's some changes we can just not escape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is better reviewed commit by commit
Closes #96
Closes #103