feat(server): add -stats-interval flag#5
Open
TheHuman00 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a configurable stats logging cadence to the roughtime server by promoting the interval to a CLI flag and wiring it through runtime behavior and validation.
Changes:
- Introduces
-stats-intervalduration flag with validation for positive values. - Updates
statsLoopand server config logging to use the flag value. - Updates tests and README to reflect the new flag behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cmd/roughtime/main.go | Adds -stats-interval flag, validates it, and logs configured value. |
| cmd/roughtime/stats.go | Switches periodic ticker/logging to use the flag-backed interval. |
| cmd/roughtime/stats_test.go | Updates interval override to target the flag-backed duration. |
| cmd/roughtime/main_test.go | Ensures flag global statsIntervalFlag is restored after tests. |
| cmd/roughtime/bootstrap_test.go | Adds validation tests for zero/negative stats interval. |
| README.md | Documents the new -stats-interval flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run this server on my own infrastructure and the default 60s stats log cadence is too frequent for my setup. This adds a
-stats-intervalflag to make it configurable.Changes
-stats-intervalflag (default60s)statsLoopreads the flag directly, instead of a separate global variableThanks for maintaining this project, I use it daily and it works great. 😄