fix: constrain dialog panel height and make content scrollable#556
Open
vdovhanych wants to merge 1 commit into
Open
fix: constrain dialog panel height and make content scrollable#556vdovhanych wants to merge 1 commit into
vdovhanych wants to merge 1 commit into
Conversation
Agent-Logs-Url: https://github.com/vdovhanych/headplane/sessions/6f5c4643-99b6-473b-9c7b-9f608fe61a7c Co-authored-by: vdovhanych <45185420+vdovhanych@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The route approval dialog overflows the viewport when a machine advertises many subnet routes, making it impossible to scroll to routes below the fold or reach the action buttons.
Changes
app/components/dialog.tsxAlertDialog.Popupatmax-h-[90dvh]withflex flex-colso the panel never exceeds the viewportflex min-h-0 flex-1 flex-coltoFormto propagate the flex height constraint downoverflow-y-auto flex-1 min-h-0— content scrolls, buttons don'tshrink-0so Close/Confirm are always visible regardless of content lengthApplies globally to all dialogs, so any future content-heavy dialog gets the same treatment.
see attached screenshots

before:
after:
