Add key expiry disable/enable toggle#554
Open
jul13579 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a button to the node menu to disable (and re-enable) node key expiry, as requested by #553. Since headscale does not store the key expiry toggle state separately from the actual expiry date, re-enabling key expiry sadly currently will result in a node that expired at the time of re-enabling the key expiry. This is not the case with official tailscale, which seems to pick up the original key expiry date from before key expiry was disabled. Hence, I'm actually unsure myself if this feature adds much to the UX of headplane 🤷