Skip to content

[codex] Add public Paykit payments to contacts#531

Open
ben-kaufman wants to merge 7 commits intomasterfrom
codex-paykit-public-endpoints-pr527
Open

[codex] Add public Paykit payments to contacts#531
ben-kaufman wants to merge 7 commits intomasterfrom
codex-paykit-public-endpoints-pr527

Conversation

@ben-kaufman
Copy link
Copy Markdown
Contributor

@ben-kaufman ben-kaufman commented Apr 29, 2026

Summary

  • Add public Paykit payments for saved contacts and scanned/pasted Pubky contacts.
  • Publish wallet payment endpoints from the Pay Contacts settings flow.
  • Support Lightning, on-chain, and combined BIP21 contact payment requests using the existing send flow.
  • Update Paykit endpoint IDs and bindings for paykit-rs v0.1.0-rc3.

Notes

  • Pubky scan/paste opens the contact flow first; payment starts from the contact screen.
  • On-chain endpoints are selected by priority: taproot, segwit, p2sh, then legacy.
  • You can verify and see the endpoints published on https://payky.app

Validation

  • swiftformat on touched Swift files
  • git diff --check
  • xcodebuild -resolvePackageDependencies -project Bitkit.xcodeproj
  • Full app build was attempted, but still fails in existing vss-rust-client-ffi generated bindings.
  • Translation validation was attempted, but the script currently needs the missing glob dependency.

@ben-kaufman ben-kaufman changed the title [codex] Complete public Paykit contact payments [codex] Add public Paykit payments to contacts Apr 29, 2026
@ben-kaufman ben-kaufman force-pushed the codex-paykit-public-endpoints-pr527 branch from 1d622bc to 18a0af9 Compare April 29, 2026 14:10
@ben-kaufman ben-kaufman marked this pull request as ready for review April 29, 2026 14:10
@ben-kaufman ben-kaufman force-pushed the codex-paykit-public-endpoints-pr527 branch from 18a0af9 to f1a122e Compare April 29, 2026 14:14
Comment thread CHANGELOG.md Outdated
Comment thread Bitkit/Views/Contacts/ContactActivityView.swift
ben-kaufman and others added 2 commits April 29, 2026 07:25
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Comment thread Bitkit/Views/Wallets/Send/SendConfirmationView.swift
Comment thread Bitkit/Views/Wallets/Send/SendPendingScreen.swift
Comment thread Bitkit/Views/Wallets/Send/SendSuccess.swift
Comment thread Bitkit/Views/Contacts/ContactActivityView.swift Outdated
Comment thread Bitkit/Services/PublicPaykitService.swift Outdated
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 29, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant