Skip to content

fix: use actual probe result#920

Open
ovitrif wants to merge 1 commit intomasterfrom
fix/probe-actual-result
Open

fix: use actual probe result#920
ovitrif wants to merge 1 commit intomasterfrom
fix/probe-actual-result

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented Apr 29, 2026

Closes #918

Ports:

Description

Before this change, the Probing Tool reported success once a probe was sent. Now it uses the returned paymentIds, waits for matching ProbeSuccessful / ProbeFailed events, and shows the actual result.

Also adds node ID / keysend probes and bumps ldk-node-android for the required probe handle support.

Preview

N/A

QA Notes

Build & run mainnetDebug, use a wallet 1+ ready channel(s) with outbound capacity.

Success test:

  1. Settings -> Advanced -> Dev -> Probing Tool.
  2. Paste a WoS Lightning invoice within your outbound capacity.
  3. Tap Send Probe.
  4. Expected: result shows Success, duration is populated, and estimated fee appears.

Failure test:

  1. Try a CakeWallet +35k sats invoice (usually not routable, in my tests)
  2. Tap Send Probe.
  3. Expected: result shows Failed or times out, instead of immediately showing success.

Node ID probing:

  1. Paste a valid 66-char node ID.
  2. Confirm the UI asks for AMOUNT (REQUIRED).
  3. Enter a small sat amount and tap Send Probe.
  4. Expected: success/failure reflects the actual probe event; no estimated fee row is shown for node ID probes.

Optional logs:

adb logcat | grep -E "Probe|sendProbes|keysend"

@ovitrif ovitrif requested review from piotr-iohk and pwltr April 29, 2026 14:58
Comment thread CHANGELOG.md Outdated
Comment thread app/src/main/java/to/bitkit/repositories/LightningRepo.kt Outdated
Comment thread app/src/test/java/to/bitkit/repositories/LightningRepoTest.kt Outdated
@ovitrif ovitrif marked this pull request as draft April 29, 2026 15:17
@ovitrif ovitrif removed request for piotr-iohk and pwltr April 29, 2026 15:17
@ovitrif
Copy link
Copy Markdown
Collaborator Author

ovitrif commented Apr 29, 2026

patching & testing, then requesting review…

@ovitrif ovitrif force-pushed the fix/probe-actual-result branch from 2f0f118 to d35fb70 Compare April 29, 2026 15:36
@ovitrif ovitrif marked this pull request as ready for review April 29, 2026 15:51
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 29, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@ovitrif ovitrif requested review from piotr-iohk and pwltr April 29, 2026 18:35
@ovitrif ovitrif self-assigned this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: use actual probe result

1 participant