[codex] Add Pubky Ring auth callbacks#917
Open
ben-kaufman wants to merge 1 commit intomasterfrom
Open
Conversation
946e7f2 to
6d6c98f
Compare
6d6c98f to
fc79786
Compare
fc79786 to
66e7592
Compare
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Collaborator
|
Not sure if it is Bitkit or Ring, but going back to ring from Bitkit does not open the auth window correctly.
Below comparison with iOS (left), where the issue is not appearing: Screen.Recording.2026-04-29.at.11.02.47.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #913.
x-success,x-cancel,x-error, andx-source=Bitkitcallback parameters before launching Ring auth.bitkit://pubky-auth/success,bitkit://pubky-auth/cancel, andbitkit://pubky-auth/errordeeplinks in the app.completePubkyAuth()as the source of truth for successful session completion../gradlew detektreports no issues.Preview
N/A, deeplink/auth flow change.
QA Notes
Validation run:
git diff --checkpassed./gradlew detektpassed with no findings./gradlew compileDevDebugKotlinattempted, but blocked at:app:checkDevDebugAarMetadatabecause GitHub Packages credentials are missing (Username must not be null) for private Maven artifacts./gradlew testDevDebugUnitTestattempted, but blocked for the same GitHub Packages credential issueSuggested manual QA: