Facilitated Filter to Index Page as well#161
Open
KhondokerIslam wants to merge 4 commits into
Open
Conversation
Contributor
|
@Yugi-2 could you please review? |
Yugi-2
requested changes
May 15, 2026
Collaborator
Yugi-2
left a comment
Yugi-2
left a comment
There was a problem hiding this comment.
@KhondokerIslam Jazak Allahu Khairan for your contribution and I apologize for the delay in review!
Having the filter button on the index page would be an excellent addition. Could you try to reuse more of the existing button / modal code and styling? I would prefer if we could extract a shared partial to prevent duplicate code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filterwas missing in the index page, although it was available in the search result page beside the search box.I have only provided this filter component in the index pages (Please check the screen-shot for more understanding).
Allahumma bareek