fix: use non-interactive flag for Nova Sonic history and system promp…#2188
Open
prettyprettyprettygood wants to merge 1 commit intostrands-agents:mainfrom
Open
Conversation
|
Assessment: Request Changes The core fix (setting Review Categories
The approach and reasoning are solid — just needs test coverage to land safely. |
5e29239 to
25c469c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t events
Description
When a
BidiAgentsession is renewed (stopped and recreated with conversation history), Nova Sonic repeats or re-summarizes prior assistant responses. This happens because conversation history messages are sent withinteractive: True, causing Nova Sonic to treat them as new live inputs requiring a response rather than prior context.Additionally, there are no size guards on replayed history, so unbounded message accumulation can cause failures or degraded performance on session renewal.
Public API Changes
_get_text_content_start_eventnow accepts an optionalinteractiveparameter (defaults toTrue, fully backward compatible):No changes to any public-facing API. All changes are internal to
BidiNovaSonicModel.Changes
interactive: Falseso Nova Sonic treats them as prior context, not new inputsinteractive: Falseto match Nova Sonic best practicesRelated Issues
Documentation PR
Type of Change
Bug fix
Testing
Tested with a local BidiAgent harness that refreshes sessions every 30 seconds
Verified via debug logging that history messages are sent with
interactive: falseConfirmed Nova Sonic no longer repeats prior responses after session renewal
Validated that oldest messages are correctly dropped when history exceeds size limits
I ran
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.