fix variables#1911
Open
JFWooten4 wants to merge 2 commits intostellar:masterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small correctness edits in the protocol/spec documentation, fixing a couple of typos in identifier names and one hyphenation in prose.
Changes:
- Corrects the
KEY_TYPE_MUXED_ED25519enum name in SEP-51’s JSON Strkey mapping list. - Fixes a pseudocode variable typo in CAP-38 (
totalPolShares→totalPoolShares) to match the rest of the document. - Updates “opt in” to “opt-in” in CAP-38 prose for consistency/grammar.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ecosystem/sep-0051.md | Fixes a typo in a key type name in the Strkey representation list. |
| core/cap-0038.md | Fixes a variable name typo in pseudocode and corrects hyphenation in prose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.