Fix TPS/TPL conversion for max-sac-tps.#5259
Open
dmkozh wants to merge 1 commit intostellar:masterfrom
Open
Conversation
The search boundaries are defined as 'TPS', but in some places they were interpreted as TPL which led to assertion failures in some cases and always incorrect logging.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes unit mismatches in ApplyLoadMode::MAX_SAC_TPS where configuration boundaries expressed in TPS were sometimes treated as “transactions/transfers per ledger (TPL)”, causing incorrect logging and (in some cases) assertion failures during max-SAC-TPS search runs.
Changes:
- Introduces a helper to convert TPS + target close time into an equivalent per-ledger count.
- Updates
MAX_SAC_TPSpaths to use the conversion when sizing accounts and computing binary-search bounds. - Adjusts the MAX_SAC_TPS simulation test configuration to match the corrected unit handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/simulation/ApplyLoad.cpp |
Adds TPS→per-ledger conversion helper and uses it in MAX_SAC_TPS account sizing, contract funding setup, and binary-search bound calculations. |
src/simulation/test/LoadGeneratorTests.cpp |
Updates MAX_SAC_TPS test parameters to align with corrected TPS/TPL interpretation. |
marta-lokhova
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The search boundaries are defined as 'TPS', but in some places they were interpreted as TPL which led to assertion failures in some cases and always incorrect logging.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)