Skip to content

Localize provider storage setting#985

Closed
tanish19078 wants to merge 1 commit into
steipete:mainfrom
tanish19078:fix-provider-storage-localization
Closed

Localize provider storage setting#985
tanish19078 wants to merge 1 commit into
steipete:mainfrom
tanish19078:fix-provider-storage-localization

Conversation

@tanish19078
Copy link
Copy Markdown
Contributor

@tanish19078 tanish19078 commented May 16, 2026

Summary

  • Route the Advanced pane provider storage toggle through the localization helper.
  • Add English, Simplified Chinese, and Brazilian Portuguese strings for the setting title/subtitle.
  • Cover the Simplified Chinese title in the preference localization smoke test.

Fixes #971

Verification

  • git diff --check HEAD~1 HEAD

@steipete
Copy link
Copy Markdown
Owner

Thanks @tanish19078, this was the right fix.

I landed it on main as eef4e1f and added the maintainer changelog credit in 7c59f8e. I could not push the fixup/changelog back to this PR because the branch has maintainer edits disabled, so I recreated the patch locally and preserved your commit authorship.

Verified with:

  • swift test --filter PreferencesPaneSmokeTests
  • make check
  • codex-review --mode branch

@steipete steipete closed this May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

translation omission

2 participants