Show Codex account in quota warnings#973
Open
raflyazf wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Codex quota warnings can be triggered by an account that is not currently active in the UI. Without the account in the notification copy, users cannot tell which account crossed the 50% or 20% threshold, which makes multi-account usage harder to manage.
Test Plan
swift build(run with local CLT compatibility workaround forMenuHighlightStyle; full Xcode is not installed on this machine).build/lint-tools/bin/swiftformat Sources Tests --lintDYLD_FRAMEWORK_PATH=/Library/Developer/CommandLineTools/usr/lib .build/lint-tools/bin/swiftlint --strict --quietswift test --filter QuotaWarningNotificationLogicTests(blocked locally: Command Line Tools toolchain cannot load the Swift TestingTestingmodule)swift test --filter UsageStoreSessionQuotaTransitionTests(blocked locally: Command Line Tools toolchain cannot load the Swift TestingTestingmodule)