Harden demo timestamp and config validation#27
Conversation
stacknil
force-pushed
the
codex/config-change-investigation-demo
branch
from
d44bb3a to
890e5a0
Compare
stacknil
changed the title
stacknil
force-pushed
the
codex/config-change-investigation-demo
branch
2 times, most recently
from
d7ec1cc to
b566487
Compare
stacknil
force-pushed
the
codex/config-change-investigation-demo
branch
from
b566487 to
da33900
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da339009a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if isinstance(value, bool): | ||
| raise ValueError(f"{field_name} must be a positive integer.") | ||
| try: | ||
| parsed = int(value) |
There was a problem hiding this comment.
require_positive_int currently coerces values with int(value), so a YAML value like correlation_minutes: 1.5 is silently truncated to 1 instead of being rejected. Because this helper is used by validate_demo_config and build_investigations, a misconfigured fractional window can shrink the evidence window and drop expected correlated events without any error, which defeats the intent of strict config validation.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation