ci(release): create PR for versioned Makefile updates#490
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-0a297bf00-490.eastasia.1.azurestaticapps.net |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e9f00d360
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: actions/checkout@v5 | ||
| with: | ||
| ref: ${{ github.event.release.tag_name }} | ||
| ref: main |
There was a problem hiding this comment.
Generate versioned Makefiles from the release tag
For release events where main has advanced past (or otherwise differs from) the published tag, this checks out the current main Makefiles but scripts/generate-versioned-makefiles.sh pins PKG_SOURCE_URL/PKG_HASH to the release tag tarball. That can create a PR whose OpenWrt build recipe expects files/rules from main while downloading the older tagged source, so the versioned Makefiles for that release may not build. The previous tag checkout kept the template and tarball in sync; keep generating from ${{ github.event.release.tag_name }} and push the resulting commit to a PR branch targeting main.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow so generated OpenWrt versioned Makefiles are proposed via a pull request instead of being pushed directly to main.
Changes:
- Adds pull request write permissions to the versioned release job.
- Checks out
main, regenerates versioned Makefiles, and skips work if no diff exists. - Creates or updates a release-specific PR branch and PR for generated Makefile updates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --body "$BODY" | ||
| fi | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Summary
Checks