Skip to content

ci(release): create PR for versioned Makefile updates#490

Merged
stackia merged 1 commit into
mainfrom
chore/release-workflow-create-pr
May 18, 2026
Merged

ci(release): create PR for versioned Makefile updates#490
stackia merged 1 commit into
mainfrom
chore/release-workflow-create-pr

Conversation

@stackia
Copy link
Copy Markdown
Owner

@stackia stackia commented May 18, 2026

Summary

  • update the release workflow to create a PR for generated versioned Makefiles instead of pushing directly to main
  • grant pull-requests write permission for the versioned job
  • skip PR creation when generated files are already up to date

Checks

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yaml"); puts "YAML OK"'
  • git --no-pager diff --check -- .github/workflows/release.yaml

Copilot AI review requested due to automatic review settings May 18, 2026 13:08
@stackia stackia enabled auto-merge (squash) May 18, 2026 13:09
@github-actions
Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-0a297bf00-490.eastasia.1.azurestaticapps.net

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e9f00d360

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

uses: actions/checkout@v5
with:
ref: ${{ github.event.release.tag_name }}
ref: main
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Generate versioned Makefiles from the release tag

For release events where main has advanced past (or otherwise differs from) the published tag, this checks out the current main Makefiles but scripts/generate-versioned-makefiles.sh pins PKG_SOURCE_URL/PKG_HASH to the release tag tarball. That can create a PR whose OpenWrt build recipe expects files/rules from main while downloading the older tagged source, so the versioned Makefiles for that release may not build. The previous tag checkout kept the template and tarball in sync; keep generating from ${{ github.event.release.tag_name }} and push the resulting commit to a PR branch targeting main.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release workflow so generated OpenWrt versioned Makefiles are proposed via a pull request instead of being pushed directly to main.

Changes:

  • Adds pull request write permissions to the versioned release job.
  • Checks out main, regenerates versioned Makefiles, and skips work if no diff exists.
  • Creates or updates a release-specific PR branch and PR for generated Makefile updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

--body "$BODY"
fi
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@stackia stackia merged commit 92e199b into main May 18, 2026
11 checks passed
@stackia stackia deleted the chore/release-workflow-create-pr branch May 18, 2026 13:12
stackia added a commit that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants