docs(stream): clean up stale service ownership comments#485
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Documentation-only cleanup removing references to the obsolete service_owned flag from comments in the stream/connection cleanup paths, reflecting that connections always own and free their per-request service instance.
Changes:
- Updated
stream_context_cleanup()comment to drop the stalec->service_ownedreference. - Updated
stream.hdoxygen comment for the cleanup function to reflect connection-owned service lifetime. - Updated
connection_cleanup()comment to describe unconditional freeing of the per-connection service.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/stream.h | Reworded doxygen comment for stream_context_cleanup() to clarify ownership. |
| src/stream.c | Removed stale mention of c->service_owned flag in cleanup note. |
| src/connection.c | Updated comment to reflect that the service is always per-connection and freed unconditionally. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-0a297bf00-485.eastasia.1.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service_ownedreferences from stream cleanup comments.connection_cleanup()owns and frees the per-connection service instance.stream_context_cleanup()comment to reflect the current ownership model.Testing