feat(dom): toBePressed and toBePartiallyPressed#172
Conversation
| const nonCommentChildNodes = [...element.childNodes].filter(child => child.nodeType !== COMMENT_NODE_TYPE); | ||
| return nonCommentChildNodes.length === 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
For these functions, please consider if this file is the best option for them as we have 3 different files for helpers such as dom, accessibility or style. Let me know what you think!
There was a problem hiding this comment.
Thanks for the suggestion Juandi! 😺 I reviewed the helper files and decided to move isValidAriaPressed to the accessibility helpers, as it seemed like a better fit there. After looking at the other function, I felt its current location was still appropriate, so I left it where it was 😄
I've pushed the corresponding changes. Let me know what you think!
JDOM10
left a comment
JDOM10
left a comment
There was a problem hiding this comment.
Hey @KeylaMunnoz! Thank you for working on this, this is looking great! Just left a small comment 
Anything else you would like to add? @suany0805
3 participants
What has been added: