Fix MySQL expression type inference for numeric division#4391
Open
rubensantoniorosa2704 wants to merge 4 commits intosqlc-dev:mainfrom
Open
Fix MySQL expression type inference for numeric division#4391rubensantoniorosa2704 wants to merge 4 commits intosqlc-dev:mainfrom
rubensantoniorosa2704 wants to merge 4 commits intosqlc-dev:mainfrom
Conversation
6ce58c1 to
d6c15e2
Compare
Contributor
Author
|
While validating additional cases, I found a bug in inferMySQLTypeCast: it was using Fixed by reading node.TypeName.Name directly, and added end-to-end tests covering the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves MySQL expression type inference for numeric expressions, with a focus
on division.
In November 2025 I started working on this issue but closed my previous attempt because
I felt I was changing too much at once. This is a more focused version of that work, and
it's my first non-trivial contribution to this project.
What this PR does:
correctly.
for MySQL expression inference. This is intentional — operator.go has a long-standing
TODO noting that the mathematical operator logic is PostgreSQL-specific and needs to be
refactored for MySQL. This PR starts that work by providing a clear extension point per
engine.
succeeds, preserving the original fallback behavior otherwise.
DECIMAL, with nullability propagated from operands.
extract the cast target type, but that function reads TypeName.Names (Postgres-style).
The MySQL AST populates TypeName.Name, causing any CAST expression to silently fall back
to interface{}.
I would really appreciate feedback on:
the project.
Fixes #4153