v0.9.7 runtime truthfulness hotfix#321
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
v0.9.5/v0.9.6 made plain
crenter the staged full-screen live-room bridge before that bridge had runtime parity. The bridge could accept input, update an in-memory snapshot, and mark a role as working, but it did not execute real role-engine turns, stream output, use the mature permission prompt path, or persist turns as the executable runtime does. That is why users saw “working/received” state without real work.The live-room preview also hid the composer cursor and repeated identity facts across the header, overview, right rail, workspace title, and prompt, which made the screen feel ambiguous and unfinished.
What Changed
crto the executable runtime path shared withcr start.cr console --live-roomavailable, but labelled it as an explicit staged preview until v0.9.x: implement true full-screen runtime parity before making live room default #320 lands.ComposerState::cursor().crfails if it regresses to staged live-room tokens, while the explicit preview must prove preview wording.Linked Issues
Closes #317.
Closes #318.
Closes #319.
Leaves #320 open for true full-screen runtime parity before the live room can become default again.
Acceptance Criteria
#317
crno longer defaults to the staged live-room bridge.crreaches the executable runtime path with role sessions and existing permission flow.cr startremains the explicit direct runtime entrypoint.cr consoleremains read-only dashboard/snapshot inspection.cr console --live-roomremains an explicit preview/staging surface.crdoes not render staged live-room tokens.#318
Input @host; placeholder retainsAsk @hostwithout duplicate title copy.CoreRoom Workspaceonce in text-render tests.#319
crdogfood rejects staged live-room tokens.Changed Files Summary
src/main.rs.src/console_tui.rs,src/console_room.rs,src/console_live.rs.src/init.rs.tests/console_room_test.rs,src/repl/tests.rs,scripts/dogfood-v09-user-cases.py.Cargo.toml,Cargo.lock,npm/package.json,src/lib.rs,CHANGELOG.md,README.md,data/splash_content.toml,docs/DEVELOPMENT.md,docs/proposed-amendments.md,docs/v0.9-real-user-dogfood.md,docs/v0.9.4-live-room-dogfood.md,docs/images/boot-dashboard.png.Validation
cargo fmt --all -- --checkgit diff --checkcargo test --all-features --locked— 592 passed, 0 failed, 1 ignored in lib tests; integration/doc tests passed.cargo clippy --all-targets --all-features --locked -- -D warningspython3 scripts/dogfood-v09-user-cases.py— PASS; exercised fresh init, plaincrexecutable runtime entry, live console, explicit live-room preview, snapshot TUI, Nerd Font avatar pack, and README image generation.cargo build --release --lockednpm pack --dry-run— producedspytensor-coreroom-0.9.7.tgzdry-run metadata.Evidence Packet
Default path evidence: dogfood waits for the real
⚡ crruntime prompt and exits with Ctrl-D; it requiresCoreRoom v,type a task, and/help for commands, and forbidsCoreRoom Workspace,Ask @host,received the request,staged preview route, and old console fallthrough.Preview evidence: dogfood runs
cr console --live-roomin a real PTY, submits bare text and explicit@reviewerinput, requires@host staged preview route,@reviewer staged preview route, visible cursor text (cr > | Ask @host), and the “Not executing a role turn here; use plaincrorcr start” notice.Renderer evidence:
tests/console_room_test.rsasserts oneCoreRoom Workspaceoccurrence and cursor rendering for both empty and moved-cursor composer state.Tracker Update
Risks / Remaining Gaps
Rollback Plan
Revert this PR and release metadata if v0.9.7 introduces regressions. That would restore the prior v0.9.6 behavior, including the staged live room as default, so rollback should also communicate the known truthfulness regression.