Disable Series Data Entry when 'isCurrent' and 'isPrimary' can be misassigned#7182
Merged
Conversation
Contributor
Author
|
Ready for testing now! |
CarolineDenis
approved these changes
Jul 23, 2025
pashiav
suggested changes
Jul 23, 2025
Contributor
pashiav
left a comment
There was a problem hiding this comment.
- If you have more than 1 determination
- If you have more than 1 determiner in any determinations
- If you have more than 1 collector in a Collecting Event
- If you have more than 1 funding agent in a Collecting Trip
- Make sure you can bulk carry forward normally if none of the above are true.
Bugs
1. Bulk carry is not disabled when there is more than 1 funding agent in a Collecting Trip.
Record set (not same as video, just similar on test panel): https://calvertmarinemuseumgen20250721-bulk-temp-fix.test.specifysystems.org/specify/view/collectionobject/26348/?recordsetid=166
https://github.com/user-attachments/assets/4a0e5365-324a-4c73-a0d0-6e869856aba1
Collection: Invertebrates
Username: spadmin
Screen.Recording.2025-07-23.at.4.19.06.PM.mov
Contributor
Author
emenslin
approved these changes
Jul 24, 2025
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
- If you have more than 1 determination
- If you have more than 1 determiner in any determinations
- If you have more than 1 collector in a Collecting Event
- If your CO is part of a consolidated COG (Other COGTypes should work, and number of records doesn't matter for this).
- Make sure you can bulk carry forward normally if none of the above are true.
- Make sure Bulk Carry Forward works as expected on COs in non-consoldiated COGs.
Looks good, carry forward is blocked in all cases.
acwhite211
approved these changes
Jul 24, 2025
bhumikaguptaa
approved these changes
Jul 24, 2025
Collaborator
bhumikaguptaa
left a comment
There was a problem hiding this comment.
- If you have more than 1 determination
- If you have more than 1 determiner in any determinations
- If you have more than 1 collector in a Collecting Event
- If your CO is part of a consolidated COG (Other COGTypes should work, and number of records doesn't matter for this).
- Make sure you can bulk carry forward normally if none of the above are true.
- Make sure Bulk Carry Forward works as expected on COs in non-consoldiated COGs.
works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Temporary fix for #5022 for Series Entry.
Disables Bulk Carry Forward Range if you have more than one record on the following dependent relationships:
Bulk Carry Forward Count is unchanged by this PR.
Checklist
self-explanatory (or properly documented)
Testing instructions