Skip to content

Add series entry field to form (series=true)#6871

Draft
alesan99 wants to merge 40 commits into
mainfrom
issue-6276-form
Draft

Add series entry field to form (series=true)#6871
alesan99 wants to merge 40 commits into
mainfrom
issue-6276-form

Conversation

@alesan99
Copy link
Copy Markdown
Contributor

@alesan99 alesan99 commented Jul 1, 2025

Fixes #
image

An addition to my Series Entry PR.

This allows you to use initialize="series=true" on the catalog number field to see the range on the form itself.

Works, but the code is somewhat hacky at the moment.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Enable Bulk Carry Forward and show bulk carry forward range
  • Add property to cat num field
  • See that both catalog number fields appear

alesan99 added 25 commits June 18, 2025 15:42
Triggered by df184bd on branch refs/heads/issue-6276
Make range start readonly
Combine with Bulk Carry Forward
Fix carrying forward after error occurs
Triggered by 2f592f8 on branch refs/heads/issue-6276
Separate Bulk Carry Dialog
Triggered by e681fa5 on branch refs/heads/issue-6276
Triggered by 5e89f54 on branch refs/heads/issue-6276
Fix wildcard detection
Disable Carry Forward when no auto increment
Add canAutoIncrement method to formatters
@github-project-automation github-project-automation Bot moved this to 📋Back Log in General Tester Board Jul 1, 2025
@alesan99 alesan99 marked this pull request as draft July 2, 2025 12:34
Base automatically changed from issue-6276 to main July 7, 2025 20:40
@CarolineDenis
Copy link
Copy Markdown
Contributor

@alesan99 could you provide the rationals behind this pr, what you already did, what still needs to be done

@alesan99
Copy link
Copy Markdown
Contributor Author

  • This PR moves the carry forward range field into the form next to the catalog number, similar to Specify 6, as requested by @grantfitzsimmons
  • This PR is functional, you can do series entry with the new field.
  • The code just needs (a lot) of refactoring for maintainability.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a9e5c4ad-1f2e-425e-852d-780c56512195

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-6276-form

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread specifyweb/frontend/js_src/lib/components/Forms/Save.tsx Fixed
Comment thread specifyweb/frontend/js_src/lib/components/Forms/Save.tsx Fixed
Comment thread specifyweb/frontend/js_src/lib/components/Forms/Save.tsx Fixed
Comment thread specifyweb/frontend/js_src/lib/components/Forms/Save.tsx Fixed
alesan99 and others added 5 commits May 21, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

3 participants