Add Network Time Protocol (NTP) support#488
Open
lo-simon wants to merge 4 commits intosony:masterfrom
Open
Conversation
…ll ensure that, if Node's clock is rewound, RDS still sees a version increment when the resource is required to be updated in RDS
…ures the time always increases even when the system clock is rewound
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following scenarios illustrate the issue that arises when the system clock is rewound. In both cases, the time used is
system_clock. To overcome this issue, we will need to usesteady_clockto obtain the request's received time at the RDS. On the Node side, we will need to usenmos::strictly_increasing_updatefor the resource's version, which will always increment.