Fix service name generation to enforce RFC 6763 length limit#485
Fix service name generation to enforce RFC 6763 length limit#485lo-simon merged 4 commits intosony:masterfrom
Conversation
|
@lo-simon, @jonathan-r-thorpe, looks like the AMWA test suite is taking 40+ minutes to run, is that expected? |
Truncate mDNS service instance names exceeding 63 bytes with a hash suffix to ensure RFC 6763 compliance, since Avahi does not automatically truncate like mDNSResponder. Also use underscore rather than colon as the host/port separator, and declare service_name in the header. Add unit tests for service_name. Made-with: Cursor
2e5ae5d to
92e8f69
Compare
lo-simon
left a comment
There was a problem hiding this comment.
Some minor suggestions.
Co-authored-by: Simon Lo <simon.lo@sony.com>
|
@lo-simon any idea why two of the Windows 2022 runners failed fast? |
I have seen that before; most of the time, when I re-run the runner, the problem disappears. According to Google, in a CI/CD environment, the runner might have multiple network interfaces active. When Get-NetIPConfiguration runs:
To fix that, as we just need any valid IP config to proceed, pipe it to Select-Object -First 1 as shown below:
|
Hey, @lo-simon, we probably want to put the |
Nice, @garethsb, let's open another PR for this fix. |
Truncate mDNS service instance names exceeding 63 bytes with a hash suffix to ensure RFC 6763 compliance, since Avahi does not automatically truncate like mDNSResponder. Also use underscore rather than colon as the host/port separator, and declare service_name in the header. Add unit tests for service_name.
Made-with: Cursor