[multi-asic] add drop monitor patches to support multi-asic#576
Open
Yakiv-Huryk wants to merge 1 commit into
Open
[multi-asic] add drop monitor patches to support multi-asic#576Yakiv-Huryk wants to merge 1 commit into
Yakiv-Huryk wants to merge 1 commit into
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Patch list: * 0003-drop_monitor-Allow-running-multiple-instances-of-dropwatch.patch * 0004-drop_monitor-Send-hardware-drop-notifications-to-the.patch * 0005-drop_monitor-Do-not-block-a-configuration-change-if-it-is-a.patch Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
Yakiv-Huryk
force-pushed
the
dropmon-patches
branch
from
a6d8a85 to
c8f1d9d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oleksandrivantsiv
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added three downstream patches that extend Linux drop_monitor (net/core/drop_monitor.c):
Why I did it
On multi-ASIC SONIC, multiple drop monitor subscribers need to configure/subscribe without fighting the global “trace already on” / “HW monitoring already enabled” state.
Hardware drops are tied to a device’s netns; sending HW notifications only in the initial netns is wrong for per-ASIC namespaces.
Allowing idempotent config while monitoring avoids unnecessary -EBUSY when different applications resend the same parameters.
How I verified it
Manual functional tests in multi-ASIC SONiC (multiple drop monitor subscribers in per-ASIC namespaces)
Details if related
Patch upstreaming plan
These patches will not be upstreamed.