For query protocols ignore the body if the output schema has the unit type trait#1173
Merged
sugmanue merged 1 commit intosmithy-lang:mainfrom May 8, 2026
Conversation
… type trait Some services such as Neptune's AddTagsToResourceResponse operation that targets `smithy.api#Unit` for its output still returns the `ResponseMetadata` in the payload. This change ignores the response when the operation output targes Unit. See example of output below. ``` <AddTagsToResourceResponse xmlns="http://rds.amazonaws.com/doc/2014-10-31/"> <ResponseMetadata> <RequestId>abc-123</RequestId> </ResponseMetadata> </AddTagsToResourceResponse ```
mtdowling
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Some services such as Neptune's AddTagsToResourceResponse operation that targets
smithy.api#Unitfor its output still returns theResponseMetadatain the payload. This change ignores the response when the operation output targes Unit. See example of output below.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.