Skip to content

CRE-4087: Adjust local config if capability registry is used to store…#22316

Merged
cedric-cordenier merged 3 commits intodevelopfrom
CRE-4087-local-config-fix
May 6, 2026
Merged

CRE-4087: Adjust local config if capability registry is used to store…#22316
cedric-cordenier merged 3 commits intodevelopfrom
CRE-4087-local-config-fix

Conversation

@cedric-cordenier
Copy link
Copy Markdown
Contributor

@cedric-cordenier cedric-cordenier commented May 6, 2026

… OCR config

Requires

Supports

Copilot AI review requested due to automatic review settings May 6, 2026 10:00
@cedric-cordenier cedric-cordenier requested review from a team as code owners May 6, 2026 10:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

👋 cedric-cordenier, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026 •
edited
Loading

✅ No conflicts with other open PRs targeting develop

@cedric-cordenier cedric-cordenier added the build-publish Build and Publish image to SDLC label May 6, 2026
Copilot AI reviewed May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM — changes affect OCR local configuration (confirmations + polling interval) in oracle setup paths, which can impact runtime behavior and operational load.

This PR aims to adjust OCR LocalConfig when OCR config is sourced dynamically from the capability registry (via OCRConfigService), so nodes react to config changes faster and don’t wait on irrelevant block confirmations.

Changes:

  • Adds a helper to adjust ocrtypes.LocalConfig for registry-based config (skip config confirmations + set a 5s poll interval).
  • Applies the adjustment when using registry-based config for the Vault DKG oracle and DonTime plugin.
  • Logs when dynamic OCR config from the registry is used.

Scrupulous human review recommended (specific blocks):

  • newServicesVaultPlugin registry-based config path (main vault oracle): confirm LocalConfig is adjusted consistently with the DKG path.
  • newDonTimePlugin registry-based config path: confirm the adjustment is applied exactly once and only under the intended conditions (current flow appears redundant due to an unconditional adjustment later).

Comment thread core/services/ocr2/delegate.go Outdated
Comment thread core/services/ocr2/delegate.go
Comment thread core/services/ocr2/delegate.go Outdated
Comment thread core/services/ocr2/delegate.go Outdated
@cedric-cordenier cedric-cordenier force-pushed the CRE-4087-local-config-fix branch from 4e08b98 to 3846f9b Compare May 6, 2026 10:09
@cedric-cordenier cedric-cordenier force-pushed the CRE-4087-local-config-fix branch from 3846f9b to 9a3ef86 Compare May 6, 2026 10:18
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 6, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented May 6, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@cedric-cordenier cedric-cordenier enabled auto-merge May 6, 2026 12:44
@cedric-cordenier cedric-cordenier added this pull request to the merge queue May 6, 2026
Merged via the queue into develop with commit f502927 May 6, 2026
230 of 231 checks passed
@cedric-cordenier cedric-cordenier deleted the CRE-4087-local-config-fix branch May 6, 2026 13:55
yashnevatia pushed a commit that referenced this pull request May 7, 2026
@cedric-cordenier @yashnevatia
CRE-4087: Adjust local config if capability registry is used to store… (
8236173 
#22316)

* CRE-4087: Adjust local config if capability registry is used to store OCR config

* CRE-4087: Adjust local config if capability registry is used to store OCR config

* Small refactor
yashnevatia pushed a commit that referenced this pull request May 8, 2026
@cedric-cordenier @yashnevatia
CRE-4087: Adjust local config if capability registry is used to store… (
875e10a 
#22316)

* CRE-4087: Adjust local config if capability registry is used to store OCR config

* CRE-4087: Adjust local config if capability registry is used to store OCR config

* Small refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@MStreet3 MStreet3 MStreet3 approved these changes

@ettec ettec ettec approved these changes

@Atrax1 Atrax1 Awaiting requested review from Atrax1

@dimriou dimriou Awaiting requested review from dimriou

Assignees

No one assigned

Labels

build-publish Build and Publish image to SDLC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cedric-cordenier @MStreet3 @ettec