chore: swap solana state usages to use cld-changesets#22310
Draft
chore: swap solana state usages to use cld-changesets#22310
Conversation
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
# Conflicts: # deployment/go.mod # deployment/go.sum
Contributor
|
I see you updated files related to
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how Solana MCMS (Multi-Chain Management System) state is loaded and managed across several deployment changeset files. The main improvement is consolidating the logic for loading Solana MCMS state into the shared
cld-changesets/pkg/family/solanapackage, replacing previous usage of the localcommon/changeset/statepackage throughout the codebase. This change simplifies dependencies and ensures a single source of truth for Solana MCMS state handling.Key changes:
Solana MCMS State Handling Refactor
MaybeLoadMCMSWithTimelockChainStateSolanaand related types from thecommon/changeset/statepackage with the equivalent functions and types fromcld-changesets/pkg/family/solana(solstate). This affects logic for loading, validating, and using MCMS state in Solana changesets. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Imports and Type Cleanup
Updated imports in all affected files to remove references to the old
common/changeset/statepackage and add the newsolstateimport. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Changed type definitions and usages to reference
solstate.MCMSWithTimelockStateinstead of the previous type fromcommonstate. [1] [2]Utility Function Migration
GetTimelockSignerPDAto use the version fromsolstateinstead of the old package. [1] [2]This refactor reduces code duplication, streamlines Solana MCMS state management, and improves maintainability by centralizing related logic.