[Warlock] Always process Shard Instability buff#11422
Merged
nyterage merged 1 commit intosimulationcraft:midnightfrom Apr 29, 2026
Merged
[Warlock] Always process Shard Instability buff#11422nyterage merged 1 commit intosimulationcraft:midnightfrom
nyterage merged 1 commit intosimulationcraft:midnightfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To implement the Blizzard hotfixes introduced in the previous Warlock PR (#11421), a condition was added so that the Shard Instability buff would not be consumed if the Unstable Affliction executed was not instant or if it came from the Fatal Echoes proc. However, an additional check was also added requiring the Shard Instability talent to be selected, which is incorrect.
In Hellcaller, this buff can also be gained without having the Shard Instability talent selected. As a result, in that case (Hellcaller with Shard Instability talent not selected), the buff would never be consumed, while UA would still benefit from it, which is incorrect.
This PR fixes that issue.