Skip to content

Add new railcars: Škoda 71E & Newag 36WEd#137

Merged
Julian-Louis merged 2 commits into
simrail:mainfrom
fm-mf:new_railcars
May 18, 2026
Merged

Add new railcars: Škoda 71E & Newag 36WEd#137
Julian-Louis merged 2 commits into
simrail:mainfrom
fm-mf:new_railcars

Conversation

@fm-mf
Copy link
Copy Markdown
Contributor

@fm-mf fm-mf commented May 17, 2026

Adding new railcars from the two recent DLCs

Summary by CodeRabbit

  • New Features
    • Added new locomotive models with multiple variants in the 163 designation series
    • Added new electric multiple unit options featuring multiple Impuls configurations for expanded transportation choices

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: df8ea0f5-8e85-4a03-829d-03c9bf546933

📥 Commits

Reviewing files that changed from the base of the PR and between 41068d7 and c53a731.

⛔ Files ignored due to path filters (25)
  • packages/map/public/trains/163_021-9.png is excluded by !**/*.png
  • packages/map/public/trains/163_029-2.png is excluded by !**/*.png
  • packages/map/public/trains/163_030-0.png is excluded by !**/*.png
  • packages/map/public/trains/163_034-2.png is excluded by !**/*.png
  • packages/map/public/trains/163_035-9.png is excluded by !**/*.png
  • packages/map/public/trains/163_040-9.png is excluded by !**/*.png
  • packages/map/public/trains/163_041-7.png is excluded by !**/*.png
  • packages/map/public/trains/163_042-5.png is excluded by !**/*.png
  • packages/map/public/trains/163_043-3.png is excluded by !**/*.png
  • packages/map/public/trains/163_045-8.png is excluded by !**/*.png
  • packages/map/public/trains/163_046-6.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-001.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-002.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-003.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-004.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-005.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-006.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-007.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-008.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-009.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-010.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-011.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-012.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-013.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-014.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • packages/map/components/railcars.json

📝 Walkthrough

Walkthrough

This pull request extends the railcar catalog by adding two complete new vehicle families: Škoda Plzeň 163 locomotives (six variants) and Newag Impuls 36WEd electric multiple units (fourteen variants), with all entries properly integrated into the existing JSON structure.

Changes

Railcar Catalog Extension

Layer / File(s) Summary
Catalog Closure and Locomotive Variants
packages/map/components/railcars.json
Closes the preceding 406Rb railcar object. Adds Škoda Plzeň locomotive variants for designation 163 (CD163/1–CD163/6) with type 71E, shared DLC requirement 4009020, and consistent specifications (weight 84.5, length 16.8, width 3, maxSpeed 120).
Electric Multiple Unit Variants
packages/map/components/railcars.json
Adds Newag Impuls electric multiple unit variants (36wed-001 through 36wed-014) with type 36WEd, shared DLC requirement 4380650, and consistent specifications (weight 111, length 59.3, width 3, maxSpeed 160) across all variants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A JSON catalog grows so tall,
With Skoda trains and Newag cars,
New locomotives heed the call,
While EMUs race like distant stars. 🚂✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding two new railcar types (Škoda 71E and Newag 36WEd) to the catalog, which directly matches the 350-line addition of locomotive and electric multiple unit records.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Julian-Louis Julian-Louis merged commit a970c8e into simrail:main May 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants