Skip to content

Remove Scripture nav controls#75

Merged
imnasnainaec merged 4 commits into
mainfrom
nix-scripture-controls
May 19, 2026
Merged

Remove Scripture nav controls#75
imnasnainaec merged 4 commits into
mainfrom
nix-scripture-controls

Conversation

@imnasnainaec
Copy link
Copy Markdown
Contributor

@imnasnainaec imnasnainaec commented May 15, 2026

Resolves #68

Note: the Scripture nav control was only removed from the Scripture tab for "simple" mode, but is still there for "power" mode:
Screenshot 2026-05-15 135012

Screenshot 2026-05-15 135152 Screenshot 2026-05-15 135135

One issue with this was posted for discussion in the Platform.Bible discord: https://discord.com/channels/1064938364597436416/1504844969566011463

UPDATE: core issue resolved in paranext/paranext-core#2290


This change is Reviewable

Summary by CodeRabbit

Release Notes

  • New Features

    • Navigation controls visibility now adapts based on interface mode setting; controls are hidden in simple mode and visible in power mode.
  • Tests

    • Expanded test coverage to verify navigation controls behavior across different interface mode configurations.

Review Change Stack

@imnasnainaec imnasnainaec self-assigned this May 15, 2026
@imnasnainaec imnasnainaec added the 🟨Medium Medium-priority PR label May 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 16641349-c4d1-4bf7-955b-bb10bc7cf4ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nix-scripture-controls

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@imnasnainaec imnasnainaec marked this pull request as draft May 15, 2026 13:27
imnasnainaec and others added 3 commits May 15, 2026 09:31
This reverts commits 81b1a89 and 2e30e30.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use `useSetting('platform.interfaceMode', 'simple')` in InterlinearizerLoader
and render ScriptureNavControls only when the value is 'power'.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@imnasnainaec imnasnainaec force-pushed the nix-scripture-controls branch from c7606e9 to 062863b Compare May 15, 2026 18:43
@imnasnainaec imnasnainaec marked this pull request as ready for review May 19, 2026 14:43
Copy link
Copy Markdown
Contributor

@alex-rawlings-yyc alex-rawlings-yyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-rawlings-yyc reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec imnasnainaec merged commit 75c422f into main May 19, 2026
8 checks passed
@imnasnainaec imnasnainaec deleted the nix-scripture-controls branch May 19, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟨Medium Medium-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Scripture Controls

2 participants